Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

Site removes {{ }} message placeholders #661

Closed
mdjermanovic opened this issue Dec 2, 2019 · 1 comment · Fixed by eslint/eslint#12643
Closed

Site removes {{ }} message placeholders #661

mdjermanovic opened this issue Dec 2, 2019 · 1 comment · Fixed by eslint/eslint#12643
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug The site is working incorrectly

Comments

@mdjermanovic
Copy link
Member

{{character}} placeholder is not visible on the site:

https://eslint.org/docs/developer-guide/working-with-rules#suggestion-messageids

https://eslint.org/docs/developer-guide/working-with-rules#placeholders-in-suggestion-messages

It's visible on GitHub:

https://github.com/eslint/eslint/blob/master/docs/developer-guide/working-with-rules.md#suggestion-messageids

https://github.com/eslint/eslint/blob/master/docs/developer-guide/working-with-rules.md#placeholders-in-suggestion-messages

Not familiar with the tool, but it could be that only {{}} without spaces has a meaning because this problem doesn't occur with {{ identifier }} and {{ name }}:

https://eslint.org/docs/developer-guide/working-with-rules#messageids

Actually, there is #312 in the list of related issues :-) This should be solved with {% raw %} ?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Dec 2, 2019
@kaicataldo
Copy link
Member

Nice find! This does look like a similar case to the issue listed. {{}} denotes interpolated data in liquid, and it’s not rendering anything because that data key is returning a null value in that context. I’ll fix this ASAP tomorrow.

@kaicataldo kaicataldo added bug The site is working incorrectly and removed triage An ESLint team member will look at this issue soon labels Dec 2, 2019
@kaicataldo kaicataldo added the accepted There is consensus among the team that this change meets the criteria for inclusion label Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug The site is working incorrectly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants