Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not install multi tseslint versions #94

Merged
merged 1 commit into from Apr 16, 2024
Merged

fix: not install multi tseslint versions #94

merged 1 commit into from Apr 16, 2024

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Apr 10, 2024

The ts style guide typically depend on tseslint, so there's no need to install it separately. Doing so might result in multiple versions being installed, leading to errors.

fixes #97, #98

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Apr 10, 2024
@aladdin-add aladdin-add marked this pull request as draft April 10, 2024 14:11
The ts style guide typically depend on tseslint, so there's no need
to install it separately. Doing so might result in multiple versions
being installed, leading to errors.

fixes #97, #98
@aladdin-add aladdin-add marked this pull request as ready for review April 16, 2024 09:33
@aladdin-add aladdin-add changed the title fix: not config tseslint twice fix: not install multi tseslint versions Apr 16, 2024
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Merging this now as an important fix to get into a patch release.

@mdjermanovic mdjermanovic merged commit ba1a02c into main Apr 16, 2024
10 checks passed
@mdjermanovic mdjermanovic deleted the issue93 branch April 16, 2024 11:29
@github-actions github-actions bot mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Key "plugins": Cannot redefine plugin "@typescript-eslint"
2 participants