Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add React example #152

Merged
merged 3 commits into from Aug 2, 2020
Merged

Docs: Add React example #152

merged 3 commits into from Aug 2, 2020

Conversation

btmills
Copy link
Member

@btmills btmills commented Jul 18, 2020

No description provided.

@btmills
Copy link
Member Author

btmills commented Jul 19, 2020

Rebased this on top of #153 to take advantage of the recommended config.

platinumazure
platinumazure previously approved these changes Aug 1, 2020
kaicataldo
kaicataldo previously approved these changes Aug 1, 2020
Base automatically changed from recommended to master August 2, 2020 20:37
@btmills btmills dismissed stale reviews from kaicataldo and platinumazure August 2, 2020 20:37

The base branch was changed.

@btmills
Copy link
Member Author

btmills commented Aug 2, 2020

GitHub auto-dismissed the approvals when the recommended base branch was merged to master, but the content of the pull request hasn't changed, so I'll consider them current and merge.

@btmills btmills merged commit f2d4923 into master Aug 2, 2020
@btmills btmills deleted the example-react branch August 2, 2020 20:43
btmills added a commit that referenced this pull request Aug 15, 2020
The 2.0.0-rc.0 release attempt failed when trying to run the examples'
tests because their dependencies were never installed. In #152, I added
an install step to the GitHub Actions workflow but not the Jenkins
release flow. This change adds an `install-examples` npm script and
calls it both from the GitHub Actions workflow and the
`generate-.*release` scripts.
btmills added a commit that referenced this pull request Aug 15, 2020
The 2.0.0-rc.0 release attempt failed when trying to run the examples'
tests because their dependencies were never installed. In #152, I added
an install step to the GitHub Actions workflow but not the Jenkins
release flow. This change adds an `install-examples` npm script and
calls it both from the GitHub Actions workflow and the
`generate-.*release` scripts.
btmills added a commit that referenced this pull request Aug 20, 2020
The 2.0.0-rc.0 release attempt failed when trying to run the examples'
tests because their dependencies were never installed. In #152, I added
an install step to the GitHub Actions workflow but not the Jenkins
release flow. This change adds an `install-examples` npm script and
calls it both from the GitHub Actions workflow and the
`generate-.*release` scripts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants