Breaking: Update eslint:recommended (fixes #4953)

conf/eslint.json

@@ -7,28 +7,28 @@
         "no-arrow-condition": 0,
         "no-bitwise": 0,
         "no-caller": 0,
-        "no-case-declarations": 0,
+        "no-case-declarations": 2,
         "no-catch-shadow": 0,
-        "no-class-assign": 0,
+        "no-class-assign": 2,
         "no-cond-assign": 2,
         "no-confusing-arrow": 0,
         "no-console": 2,
-        "no-const-assign": 0,
+        "no-const-assign": 2,
         "no-constant-condition": 2,
         "no-continue": 0,
         "no-control-regex": 2,
         "no-debugger": 2,
         "no-delete-var": 2,
         "no-div-regex": 0,
-        "no-dupe-class-members": 0,
+        "no-dupe-class-members": 2,
         "no-dupe-keys": 2,
         "no-dupe-args": 2,
         "no-duplicate-case": 2,
         "no-else-return": 0,
         "no-empty": 2,
         "no-empty-character-class": 2,
-        "no-empty-label": 0,
-        "no-empty-pattern": 0,
+        "no-empty-label": 2,
+        "no-empty-pattern": 2,
         "no-eq-null": 0,
         "no-eval": 0,
         "no-ex-assign": 2,
@@ -68,7 +68,7 @@
         "no-new-func": 0,
         "no-new-object": 0,
         "no-new-require": 0,
-        "no-new-symbol": 0,
+        "no-new-symbol": 2,
         "no-new-wrappers": 0,
         "no-obj-calls": 2,
         "no-octal": 2,
@@ -96,12 +96,12 @@
         "no-sync": 0,
         "no-ternary": 0,
         "no-trailing-spaces": 0,
-        "no-this-before-super": 0,
+        "no-this-before-super": 2,
         "no-throw-literal": 0,
         "no-undef": 2,
         "no-undef-init": 0,
         "no-undefined": 0,
-        "no-unexpected-multiline": 0,
+        "no-unexpected-multiline": 2,
         "no-underscore-dangle": 0,
         "no-unmodified-loop-condition": 0,
         "no-unneeded-ternary": 0,
@@ -136,7 +136,7 @@
         "computed-property-spacing": 0,
         "consistent-return": 0,
         "consistent-this": 0,
-        "constructor-super": 0,
+        "constructor-super": 2,
         "curly": 0,
         "default-case": 0,
         "dot-location": 0,

docs/rules/README.md

@@ -31,7 +31,7 @@ The following rules point out areas where you might have made mistakes.
 * [no-obj-calls](no-obj-calls.md) - disallow the use of object properties of the global object (`Math` and `JSON`) as functions (recommended)
 * [no-regex-spaces](no-regex-spaces.md) - disallow multiple spaces in a regular expression literal (recommended)
 * [no-sparse-arrays](no-sparse-arrays.md) - disallow sparse arrays (recommended)
-* [no-unexpected-multiline](no-unexpected-multiline.md) - Avoid code that looks like two expressions but is actually one
+* [no-unexpected-multiline](no-unexpected-multiline.md) - Avoid code that looks like two expressions but is actually one (recommended)
 * [no-unreachable](no-unreachable.md) - disallow unreachable statements after a return, throw, continue, or break statement (recommended)
 * [use-isnan](use-isnan.md) - disallow comparisons with the value `NaN` (recommended)
 * [valid-jsdoc](valid-jsdoc.md) - Ensure JSDoc comments are valid
@@ -54,11 +54,11 @@ These are rules designed to prevent you from making mistakes. They either prescr
 * [guard-for-in](guard-for-in.md) - make sure `for-in` loops have an `if` statement
 * [no-alert](no-alert.md) - disallow the use of `alert`, `confirm`, and `prompt`
 * [no-caller](no-caller.md) - disallow use of `arguments.caller` or `arguments.callee`
-* [no-case-declarations](no-case-declarations.md) - disallow lexical declarations in case clauses
+* [no-case-declarations](no-case-declarations.md) - disallow lexical declarations in case clauses (recommended)
 * [no-div-regex](no-div-regex.md) - disallow division operators explicitly at beginning of regular expression
 * [no-else-return](no-else-return.md) - disallow `else` after a `return` in an `if`
-* [no-empty-label](no-empty-label.md) - disallow use of labels for anything other than loops and switches
-* [no-empty-pattern](no-empty-pattern.md) - disallow use of empty destructuring patterns
+* [no-empty-label](no-empty-label.md) - disallow use of labels for anything other than loops and switches (recommended)
+* [no-empty-pattern](no-empty-pattern.md) - disallow use of empty destructuring patterns (recommended)
 * [no-eq-null](no-eq-null.md) - disallow comparisons to null without a type-checking operator
 * [no-eval](no-eval.md) - disallow use of `eval()`
 * [no-extend-native](no-extend-native.md) - disallow adding to native types
@@ -217,14 +217,14 @@ These rules are only relevant to ES6 environments.
 * [arrow-body-style](arrow-body-style.md) - require braces in arrow function body
 * [arrow-parens](arrow-parens.md) - require parens in arrow function arguments
 * [arrow-spacing](arrow-spacing.md) - require space before/after arrow function's arrow (fixable)
-* [constructor-super](constructor-super.md) - verify calls of `super()` in constructors
+* [constructor-super](constructor-super.md) - verify calls of `super()` in constructors (recommended)
 * [generator-star-spacing](generator-star-spacing.md) - enforce spacing around the `*` in generator functions (fixable)
-* [no-class-assign](no-class-assign.md) - disallow modifying variables of class declarations
+* [no-class-assign](no-class-assign.md) - disallow modifying variables of class declarations (recommended)
 * [no-confusing-arrow](no-confusing-arrow.md) - disallow arrow functions where they could be confused with comparisons
-* [no-const-assign](no-const-assign.md) - disallow modifying variables that are declared using `const`
-* [no-dupe-class-members](no-dupe-class-members.md) - disallow duplicate name in class members
-* [no-new-symbol](no-new-symbol.md) - disallow use of the `new` operator with the `Symbol` object
-* [no-this-before-super](no-this-before-super.md) - disallow use of `this`/`super` before calling `super()` in constructors.
+* [no-const-assign](no-const-assign.md) - disallow modifying variables that are declared using `const` (recommended)
+* [no-dupe-class-members](no-dupe-class-members.md) - disallow duplicate name in class members (recommended)
+* [no-new-symbol](no-new-symbol.md) - disallow use of the `new` operator with the `Symbol` object (recommended)
+* [no-this-before-super](no-this-before-super.md) - disallow use of `this`/`super` before calling `super()` in constructors (recommended)
 * [no-var](no-var.md) - require `let` or `const` instead of `var`
 * [no-useless-constructor](no-useless-constructor.md) - disallow unnecessary constructor
 * [object-shorthand](object-shorthand.md) - require method and property shorthand syntax for object literals