Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node.js API docs: CLIEngine#getConfigForFile references deprecated linter property #10228

Closed
platinumazure opened this issue Apr 16, 2018 · 3 comments
Closed

Node.js API docs: CLIEngine#getConfigForFile references deprecated linter property #10228

platinumazure opened this issue Apr 16, 2018 · 3 comments
Assignees
@nzakas
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation

Comments

@platinumazure
Copy link
Member

CLIEngine#getConfigForFile references require("eslint").linter in an example. Might be better to reference require("eslint").Linter instead.

Can be found here.
@platinumazure platinumazure added documentation Relates to ESLint's documentation evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Apr 16, 2018
@santanaG
Copy link
Contributor

Is there anything else left to evaluate here? I can make the change on the go ahead.

@platinumazure platinumazure added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Aug 22, 2018
@platinumazure
Copy link
Member Author

Hi @santanaG, I don't think so, mostly I wanted to give the team a chance to object. But we've had more than enough time 😄

I've marked this as "accepted" and look forward to your PR. Thanks!

@nzakas nzakas self-assigned this Sep 17, 2018
@nzakas nzakas mentioned this issue Sep 17, 2018
Merged
@nzakas
Copy link
Member

nzakas commented Sep 17, 2018

Fixed by # 10864

@nzakas nzakas closed this as completed Sep 17, 2018
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 17, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nzakas nzakas

Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nzakas @platinumazure @santanaG