Build: add Node v10 to travis

[alberto]

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

What changes did you make? (Give an overview)
Add Node v10 to travis

Is there anything you'd like reviewers to focus on?
No

[mysticatea]

Thank you.

Looks to need to fix a test.

-     }, /Output is incorrect\. \(' foo = bar;' === 'invalid output'\)$/);
+     }, /Output is incorrect\. \(' foo = bar;' (?:===|strictEqual) 'invalid output'\)$/);

tests/lib/testers/no-test-runners.js#L29

[alberto]

Yes, thanks for pointing it out.

[mysticatea]

Hmm, I'm not sure what the new test failings are.
I couldn't reproduce those failings in my PC... I could.

[alberto]

Ugh, I used the wrong node version locally 🤦‍♂️ I'll have a look at it later.

[not-an-aardvark]

I think the test failures are fixed in #10182.

[platinumazure]

After merging #10182, it seems there are still some errors we might need to look at. So we decided to hold off on merging this for tonight's alpha release.

[alberto]

Ok, sorry it took so long. I think I've traced at least some of the errors down to an issue with mockFs and changes in fs.statSync (called here).

[tschaub]

@alberto mock-fs@4.5 has been published with Node 10 support.

[alberto]

Awesome! Thanks @tschaub

[not-an-aardvark]

Can we update this assertion to use something like this strategy for matching messages? Using a regex for error messages has caused problems when error messages change in Node core (see #10111).

[alberto]

I'm sorry I had some problems getting the test to fail for the right reason and then got busy, so if anyone wants to take over this, feel free to do so.

[aladdin-add]

Just pushed a commit to fix the message. 🚀

[platinumazure]

LGTM, thanks!