Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Correct wording in the smart-tabs docs page #10277

Merged
merged 1 commit into from Apr 27, 2018

Conversation

j-f1
Copy link
Contributor

@j-f1 j-f1 commented Apr 27, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

I corrected the wording for the smart-tabs option in the no-mixed-spaces-and-tabs rule’s docs. Before, it implied that spaces would be used for indentation and tabs for alignment.

Is there anything you'd like reviewers to focus on?

Is there a better way to word this?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Apr 27, 2018
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I think the wording you used is fine.

@not-an-aardvark not-an-aardvark merged commit 4672b56 into eslint:master Apr 27, 2018
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Oct 25, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion triage An ESLint team member will look at this issue soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants