Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort-keys not working with spread props #10760

Closed
csantos1113 opened this issue Aug 13, 2018 · 3 comments · Fixed by #11158
Closed

sort-keys not working with spread props #10760

csantos1113 opened this issue Aug 13, 2018 · 3 comments · Fixed by #11158
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion auto closed The bot closed this issue bug ESLint is working incorrectly evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion rule Relates to ESLint's core rules

Comments

@csantos1113
Copy link

Tell us about your environment

  • ESLint Version: 5.3.0
  • Node Version: 9.10.1
  • npm Version: 5.6.0

What parser (default, Babel-ESLint, etc.) are you using?
None
Please show your full configuration:

{
    "parserOptions": {
        "ecmaVersion": 9,
        "sourceType": "script",
        "ecmaFeatures": {}
    },
    "rules": {
        "sort-keys": 2
    },
    "env": {
        "browser": true
    }
}

What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.

const a = {
  a: 'a',
  x: 'x',
  b: 'b'
};

const b = {
  ...a,
  t: 't',
  d: 'd'
};

Fully replicable in ESLint Demo

What did you expect to happen?
I'm expecting to see errors in lines:
b: 'b' and d: 'd'

What actually happened? Please include the actual, raw output from ESLint.
I'm not getting the error in line d: 'd'

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Aug 14, 2018
@aladdin-add aladdin-add added bug ESLint is working incorrectly rule Relates to ESLint's core rules evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Aug 15, 2018
@ghost
Copy link

ghost commented Aug 18, 2018

@keepitrio and I are looking forward to working on this!

@infctr
Copy link

infctr commented Dec 6, 2018

yeah, that kinda renders this rule useless

@eslint-deprecated eslint-deprecated bot added the auto closed The bot closed this issue label Jan 6, 2019
@eslint-deprecated
Copy link

Unfortunately, it looks like there wasn't enough interest from the team
or community to implement this change. While we wish we'd be able to
accommodate everyone's requests, we do need to prioritize. We've found
that issues failing to reach accepted status after 21 days tend to
never be accepted, and as such, we close those issues.
This doesn't mean the idea isn't interesting or useful, just that it's
not something the team can commit to.

Thanks for contributing to ESLint and we appreciate your understanding.

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jul 6, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jul 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion auto closed The bot closed this issue bug ESLint is working incorrectly evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants