Fix: wrong 'plugin-missing' error on Node.js 12 (fixes #11720)

[mysticatea]

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix: #11720 (wrong plugin-missing errors on Node.js 12)

What changes did you make? (Give an overview)

This PR fixes wrong plugin-missing errors on Node.js 12.

The config array factory distinguishes by the following way if a MODULE_NOT_FOUND error was plugin's or came from inside of the plugin.

error.code === "MODULE_NOT_FOUND" && error.message.includes(request)

Because the error.message was "Cannot find module '${request}'" until Node.js 12.

Since Node.js 12, the error.message contains the require stack. For example:

Cannot find module 'eslint/lib/util/glob-util'
Require stack:
- C:\Users\t-nagashima.AD\dev\sandbox\node_modules\eslint-plugin-import\lib\rules\no-unused-modules.js
- C:\Users\t-nagashima.AD\dev\sandbox\node_modules\eslint-plugin-import\lib\index.js
- C:\Users\t-nagashima.AD\dev\sandbox\node_modules\eslint\lib\cli-engine\config-array-factory.js
- C:\Users\t-nagashima.AD\dev\sandbox\node_modules\eslint\lib\cli-engine\cascading-config-array-factory.js
- C:\Users\t-nagashima.AD\dev\sandbox\node_modules\eslint\lib\cli-engine.js
- C:\Users\t-nagashima.AD\dev\sandbox\node_modules\eslint\lib\cli.js
- C:\Users\t-nagashima.AD\dev\sandbox\node_modules\eslint\bin\eslint.js

Then, error.message.includes(request) (that request is eslint-plugin-import in that case) was true as unexpected.

Now, the config array factory checks error.requireStack if it existed. the try blocks of resolving and loading are separated.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

[not-an-aardvark]

Instead of matching on error.message, would it be possible to check where the error is thrown from?

It seems like "plugin missing" errors will always cause ModuleResolver.resolve to throw, and errors from plugin loading will cause require to throw. So we could distinguish the errors by just having two separate try blocks. (This is what the previous implementation did.)

[mysticatea]

Oh. You are right.

[mysticatea]

I updated this PR.

[not-an-aardvark]

LGTM with a small suggestion.