Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please help us getting ESLint 7 support landed for testing-library & create-react-app #13702

Closed
MichaelDeBoey opened this issue Sep 19, 2020 · 4 comments
Labels
question This issue asks a question about ESLint

Comments

@MichaelDeBoey
Copy link
Contributor

Hi team! 馃憢

I would like to ask if you guys could help us out in getting mysticatea/eslint-utils#7 merged.
I already tried contacting @mysticatea in a lot of different ways, but I haven't heard from him since July 16th when he said he would have a look at it the weekend after.

I know OSS relies on the maintainer of the packages and I'm super grateful for all the packages @mysticatea's maintaining, but this PR is blocking (at least) 7 other packages to be able to get ESLint 7 support without any problems.
The most important ones are eslint-plugin-testing-library & eslint-config-react-app.

Since @mysticatea seems to be the only person who can publish the package, we're thinking about publishing a fork if this isn't resolved within a week or two.
If the @eslint team is willing to take over the package and publish it yourself (since it's a generic enough package) that would be awesome, but we're also willing to take ownership of the package if necessary.

Hopefully we can get this sorted out and we can enjoy all the lovely packages.

Thanks for helping us out! 馃憡

CC all people involved in the depending PRs: @Belco90 @iansu @ianschmitz @kentcdodds @mrmckeb @nickmccurdy

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Sep 19, 2020
@mdjermanovic
Copy link
Member

Hi @MichaelDeBoey, thanks for the issue!

Can you please provide more details about what problems is the actual version of eslint-utils causing for other packages? What exactly wouldn't work with eslint-utils v2.1.0?

@mdjermanovic
Copy link
Member

@MichaelDeBoey thanks for your efforts to verify that a number of plugins work well with ESLint 7!

Still, I don't understand why is the set of plugins on the left side a blocker for the configs on the right side:

image

eslint-plugin-node and eslint-plugin-promise are here just devDependencies of eslint-plugin-testing-library?

@MichaelDeBoey
Copy link
Contributor Author

@mdjermanovic After looking closer into your comment, I think we can indeed merge the eslint-plugin-testing-library PR (all tests are green) and release it without all other (dev)Dependencies being ESLint 7.x compatible 馃檪

That being said: it would be lovely if you guys somehow could notice @mysticatea that there are still a some other packages waiting for mysticatea/eslint-utils#7, looking at the reactions I get on my pings



@mdjermanovic mdjermanovic added question This issue asks a question about ESLint and removed triage An ESLint team member will look at this issue soon labels Sep 20, 2020
@nzakas
Copy link
Member

nzakas commented Sep 23, 2020

Just a reminder that this repo is for issues related directly to ESLint. It鈥檚 not appropriate to file issues here about a project we don鈥檛 maintain just because the maintainer also happens to maintain ESLint.

@nzakas nzakas closed this as completed Sep 23, 2020
@eslint eslint locked as off-topic and limited conversation to collaborators Sep 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question This issue asks a question about ESLint
Projects
None yet
Development

No branches or pull requests

3 participants