Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would flow type annotations be reasonable? #1486

Closed
StoneCypher opened this issue Nov 23, 2014 · 5 comments
Closed

Would flow type annotations be reasonable? #1486

StoneCypher opened this issue Nov 23, 2014 · 5 comments

Comments

@StoneCypher
Copy link

Facebook has recently released a tool called Flow, mostly around type checking, which among other things introduces a transformation which consumes the syntaxes

function foo(bar, baz: integer, quux: string) { ... }

and

function foo(bar, baz: integer, quux: string): string { ... }

This is a potentially significant tool, but eslint barks at it (as well it should.)

Is it possible to optionally support letting these notations slide?

@nzakas
Copy link
Member

nzakas commented Nov 23, 2014

Not at this time, we'd need a parser that supports the syntax.

@nzakas nzakas closed this as completed Nov 23, 2014
@StoneCypher
Copy link
Author

Is that an issue for the esprima folks then?

If the parser supports it, would you reconsider?

@StoneCypher
Copy link
Author

Er, make that acorn

@StoneCypher
Copy link
Author

Oh my, it looks like the acorn-jsx guy is already interested 😄

acornjs/acorn-jsx#8

@nzakas
Copy link
Member

nzakas commented Nov 24, 2014

We don't have any plans to support type annotations. If a parser is available after we hit 1.0.0, we can reevaluate at that time.

@eslint eslint locked and limited conversation to collaborators Nov 24, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants