Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new docs site] Broken line numbers in code blocks #16042

Closed
mdjermanovic opened this issue Jun 22, 2022 · 4 comments · Fixed by #16606
Closed

[new docs site] Broken line numbers in code blocks #16042

mdjermanovic opened this issue Jun 22, 2022 · 4 comments · Fixed by #16606
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly documentation Relates to ESLint's documentation
Projects

Comments

@mdjermanovic
Copy link
Member

mdjermanovic commented Jun 22, 2022

Something's wrong with the line numbers in some code blocks.

For example https://new.eslint.org/docs/head/rules/function-paren-newline, see bar and baz lines.

image

Note that this isn't caused by the recently added ::: correct / ::: incorrect containers because it was the same without them:

https://new.eslint.org/docs/latest/rules/function-paren-newline

@eslint-github-bot eslint-github-bot bot added this to Needs Triage in Triage Jun 22, 2022
@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Jun 22, 2022
@mdjermanovic mdjermanovic added documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels Jun 22, 2022
@DeepshikaS
Copy link
Contributor

The bar and baz lines should be considered as highlight-line but it is currently being considered as a token, thus it's not coming in a new line. I will look into this.

@nzakas nzakas added bug ESLint is working incorrectly accepted There is consensus among the team that this change meets the criteria for inclusion labels Jun 23, 2022
@mdjermanovic mdjermanovic moved this from Needs Triage to Ready to Implement in Triage Jun 30, 2022
@nzakas
Copy link
Member

nzakas commented Jul 2, 2022

@DeepshikaS are you still working on this?

@DeepshikaS
Copy link
Contributor

@DeepshikaS are you still working on this?

The default behavior of the 11ty syntax highlighting seems to be causing the issue- falldowngoboone/falldowngoboone-com#116.
I'm trying to find out if there is any other way to solve it.

@nzakas
Copy link
Member

nzakas commented Nov 3, 2022

Triage automation moved this from Ready to Implement to Complete Dec 8, 2022
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jun 7, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly documentation Relates to ESLint's documentation
Projects
Archived in project
Triage
Complete
Development

Successfully merging a pull request may close this issue.

3 participants