New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Revert all changes after the license change #17227
Conversation
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
After reverting this PR are we immediately going to resubmit the removed documentation? boz If we revert docs changes alone then the code and docs will be inconsistent right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for going through and doing this.
I started leaving notes on each file, but basically we just need to revert the *.md files, as those are the only ones that contain documentation. All of the other file types are covered under the MIT license only and we should leave as-is.
docs/package.json
Outdated
@@ -1,7 +1,7 @@ | |||
{ | |||
"name": "docs-eslint", | |||
"private": true, | |||
"version": "8.41.0", | |||
"version": "8.36.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we probably want to keep this at 8.41.0 to match the ESLint version?
docs/src/_data/sites/en.yml
Outdated
@@ -85,7 +85,6 @@ footer: | |||
description: Selecting a language will take you to the ESLint website in that language. | |||
change_language: Change Language | |||
language: Language | |||
latest: Latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to keep this?
docs/src/_data/sites/zh-hans.yml
Outdated
@@ -83,7 +83,6 @@ footer: | |||
description: 切换到你所选择语言版本对应的 ESLint 网站。 | |||
change_language: 更改语言 | |||
language: 语言 | |||
latest: 最新 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Safe to keep
docs/src/_includes/layouts/base.html
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Safe to keep
docs/src/_includes/layouts/doc.html
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Safe to keep
docs/src/assets/js/scroll-up-btn.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Safe to Keep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Safe to keep
a3df557
to
dcf3c72
Compare
Done. This now includes only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just leaving open so we can coordinate how we want to merge this in.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Refs #17225, fixes step 2.
What changes did you make? (Give an overview)
Checked out b3634f6 and copied its
docs/
folder over the current one.Is there anything you'd like reviewers to focus on?
This reverts all docs changes after b3634f6, including the bot's and team members' commits. Is that okay?
Also, this reverts only docs parts of the commits. For example, 880a431 had changes in both code and docs. Its code changes will stay, while the docs changes will be removed. Is that okay?