Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve ignores documentation #17239

Merged
merged 3 commits into from Jun 8, 2023
Merged

docs: Improve ignores documentation #17239

merged 3 commits into from Jun 8, 2023

Conversation

fasttime
Copy link
Member

@fasttime fasttime commented Jun 4, 2023

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

This PR corrects the ignores option documentation as suggested here and here and in the 2023-06-01 TSC Meeting.

Fixes #17213

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Jun 4, 2023
@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jun 4, 2023
@fasttime
Copy link
Member Author

fasttime commented Jun 7, 2023

Rabsed on top of 788d836 (docs: add references to MIT License).

@fasttime fasttime marked this pull request as ready for review June 7, 2023 16:25
@fasttime fasttime requested a review from a team as a code owner June 7, 2023 16:25
Clarifiy a sentence

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 3912f3a into main Jun 8, 2023
17 checks passed
@mdjermanovic mdjermanovic deleted the docs-improve-ignores branch June 8, 2023 17:24
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Dec 6, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [flat config] Global ignores matches differently from non-global ignores
2 participants