Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: resubmit custom-rules doc changes #17294

Merged
merged 1 commit into from Jun 16, 2023

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Jun 15, 2023

credits: https://github.com/snitin315

Refs:

it contains the docs changes in following PRs as suggested:

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Leaving open for @snitin315 to review and as the original author give permission for these changes to be merged.

Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the original author, I give permission to merge these changes.

@snitin315 snitin315 merged commit 67e7af3 into eslint:main Jun 16, 2023
17 checks passed
@aladdin-add aladdin-add deleted the docs/custom-rules branch June 16, 2023 05:59
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Dec 14, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants