fix: Fix suggestion message in no-useless-escape
#17339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
fasttime
commented
Jul 4, 2023
fasttime
added
rule
mdjermanovic
reviewed
Jul 4, 2023
mdjermanovic
reviewed
Jul 7, 2023
mdjermanovic
approved these changes
Jul 7, 2023
bmish
added a commit
to bmish/eslint
that referenced
this pull request
Jul 23, 2023
* main: (101 commits) docs: Migrating `eslint-env` configuration comments (eslint#17390) Merge pull request from GHSA-qwh7-v8hg-w8rh feat: adds option for allowing empty object patterns as parameter (eslint#17365) fix: FlatESLint#getRulesMetaForResults shouldn't throw on unknown rules (eslint#17393) docs: fix Ignoring Files section in config migration guide (eslint#17392) docs: Update README feat: Improve config error messages (eslint#17385) fix: Update no-loop-func to not overlap with no-undef (eslint#17358) docs: Update README docs: Update README 8.45.0 Build: changelog update for 8.45.0 chore: package.json update for @eslint/js release docs: add playground links to correct and incorrect code blocks (eslint#17306) docs: Expand rule option schema docs (eslint#17198) docs: Config Migration Guide (eslint#17230) docs: Update README fix: Fix suggestion message in `no-useless-escape` (eslint#17339) docs: Update README chore: update eslint-config-eslint exports (eslint#17336) ...
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Fixes #16988
What changes did you make? (Give an overview)
This PR changes the message of a suggestion reported by the
no-useless-escaperule when the target node is a string in a directive. As per specification,"use strict"directives cannot contain escape sequences, and there is no guarantee about the evaluation of implementations-specific directives when the raw text is changed.Since it cannot be assumed that replacing escape sequences in a directive will keep the existing functionality, the new message omits that information:
instead of
This is the last remaining effort to complete #16988.
Is there anything you'd like reviewers to focus on?
I factored out the method
isDirectivefrom a rule intoast-utils.js, and noticed that a shorter implementation exists. I can't decide if the previous implementation should be kept as a fallback because I don't know what the requirements for custom parsers are. See https://github.com/eslint/eslint/pull/17339/files#r1251818127.