Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove defaultIgnores from FlatESLint private members #17349

Merged
merged 1 commit into from Jul 7, 2023

Conversation

fasttime
Copy link
Member

@fasttime fasttime commented Jul 7, 2023

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Remove unused code.

What changes did you make? (Give an overview)

This PR removes the unreferenced defaultIgnores property from the private members of the FlatESLint class.

While debugging, I noticed that this property was never being used within flat config, as it appears to be a leftover of CLIEngine.

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Jul 7, 2023
@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 9e3c446
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/64a7b5af97d37800085d54e9

@fasttime fasttime marked this pull request as ready for review July 7, 2023 07:27
@fasttime fasttime requested a review from a team as a code owner July 7, 2023 07:27
@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jul 7, 2023
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit c6f8cd0 into main Jul 7, 2023
22 checks passed
@mdjermanovic mdjermanovic deleted the remove-defaultIgnores branch July 7, 2023 09:21
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jan 4, 2024
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants