feat: prefer-named-capture-group support v flag
#17409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
nzakas
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
Overall looks good. Just left one suggestion to clarify a comment. Would like @mdjermanovic to review before merging.
|
|
||
| // ES2024 | ||
| "new RegExp('(?<c>[[A--B]])', 'v')", | ||
| String.raw`new RegExp('([\\q])', 'v')` // SyntaxError |
There was a problem hiding this comment.
I think what you're saying here is that the regex intentionally has a syntax error? If so, can you expand the comment and explain why that's a useful valid test?
There was a problem hiding this comment.
Thank you for reviewing this PR. I added a comment. Could you please check again?
amareshsm
added
accepted
nzakas
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
LGTM. Just waiting for @mdjermanovic to verify his comments.
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[X] Changes an existing rule (template)
What changes did you make? (Give an overview)
Refs #17223
This PR modifies the
prefer-named-capture-grouprule and adds support for regexpvflag.Is there anything you'd like reviewers to focus on?