Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update with "Specifying Parser Options" #17435

Merged
merged 4 commits into from Aug 2, 2023
Merged

Conversation

Ryan-Dia
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

I added Supplementary explanations to the docs

Is there anything you'd like reviewers to focus on?

Motivation

After reading the explanation, I thought that having a summary at the end would be helpful for better comprehension. Therefore, I added a summarizing section at the end of the text. This may assist readers who might have had difficulty understanding the earlier parts or those who need a more organized overview. Additionally, it will make the content easier to read and more reader-friendly.

I'm always grateful

@Ryan-Dia Ryan-Dia requested a review from a team as a code owner July 31, 2023 03:18
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 31, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Jul 31, 2023
@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 6d23b99
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/64c85476fb6be40008b05122
😎 Deploy Preview https://deploy-preview-17435--docs-eslint.netlify.app/use/configure/language-options
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The additional sentence looks good, but you've also submitted a bunch of formatting changes. Can you please revert those?

@Ryan-Dia
Copy link
Contributor Author

Ryan-Dia commented Aug 1, 2023

Thanks. The additional sentence looks good, but you've also submitted a bunch of formatting changes. Can you please revert those?

I apologize. I have reverted the formatting changes to their original state.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Would like @fasttime to verify his comments were addressed before merging.

Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit 2a92b6c into eslint:main Aug 2, 2023
22 checks passed
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jan 30, 2024
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants