Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document lack of config file names #17442

Merged
merged 3 commits into from Aug 4, 2023
Merged

docs: document lack of config file names #17442

merged 3 commits into from Aug 4, 2023

Conversation

Zamiell
Copy link
Contributor

@Zamiell Zamiell commented Aug 1, 2023

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

I had a very confusing time reading the ESLint docs today so I think this extra warning section will really help ESLint users who are migrating.

Is there anything you'd like reviewers to focus on?

No.

@Zamiell Zamiell requested a review from a team as a code owner August 1, 2023 17:32
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Aug 1, 2023
@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 11c396d
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/64ca8233f7cb6d0008a3d031
😎 Deploy Preview https://deploy-preview-17442--docs-eslint.netlify.app/use/configure/configuration-files-new
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
@amareshsm amareshsm added the accepted There is consensus among the team that this change meets the criteria for inclusion label Aug 2, 2023
@nzakas
Copy link
Member

nzakas commented Aug 4, 2023

LGTM. Thanks.

@nzakas nzakas merged commit a766a48 into eslint:main Aug 4, 2023
22 checks passed
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Feb 1, 2024
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants