Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Circular references in flat config cause crash #17665

Closed
1 task done
nzakas opened this issue Oct 19, 2023 · 3 comments · Fixed by #17752
Closed
1 task done

Bug: Circular references in flat config cause crash #17665

nzakas opened this issue Oct 19, 2023 · 3 comments · Fixed by #17752
Assignees
@fasttime
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly repro:yes

Comments

@nzakas
Copy link
Member

nzakas commented Oct 19, 2023

Environment

HEAD

What parser are you using?

Default (Espree)

What did you do?

Ran the CLI with a circular reference in eslint.config.js.

Configuration 
const circular = {};
circular.self = circular;

module.exports = [{
                settings: {
                    sharedData: circular
                }
            }]);


let foo;

What did you expect to happen?

ESLint to run and exit correctly.

What actually happened?

ESLint crashes:

❯ npx eslint index.js

Oops! Something went wrong! :(

ESLint: 8.49.0

deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:77:9
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31
deepMerge@file:///home/projects/stackblitz-starters-yk4rv3/node_modules/eslint/lib/config/flat-config-schema.js:95:31

Link to Minimal Reproducible Example

https://stackblitz.com/edit/stackblitz-starters-yk4rv3?file=eslint.config.js

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response
@nzakas nzakas added bug ESLint is working incorrectly repro:needed labels Oct 19, 2023
@fasttime
Copy link
Member

fasttime commented Nov 4, 2023

I am able to reproduce this. It looks like the deepMerge algorithm needs to be fixed so it doesn't recurse endlessly on circular references.

@nzakas
Copy link
Member Author

nzakas commented Nov 6, 2023

Exactly. I made a first-pass attempt at fixing this but didn't get very far. Just wanted to record it as an issue so we don't forget. If it interests you, please feel free to take a look as I will be held up on v9 tasks for a while.

@nzakas nzakas added the accepted There is consensus among the team that this change meets the criteria for inclusion label Nov 6, 2023
@fasttime
Copy link
Member

fasttime commented Nov 7, 2023

Sure, I will look into this.

@fasttime fasttime self-assigned this Nov 7, 2023
@fasttime fasttime mentioned this issue Nov 12, 2023
Merged
1 task
@mdjermanovic mdjermanovic mentioned this issue Jan 31, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fasttime fasttime

Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly repro:yes
Projects
Triage
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow circular references in config eslint/eslint
2 participants
@nzakas @fasttime