feat!: Require Node.js `^18.18.0 || ^20.9.0 || >=21.1.0` #17725

mdjermanovic · 2023-11-06T22:52:22Z

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:

Fixes #17595

What changes did you make? (Give an overview)

Updated package.json to require:

"node": "^18.18.0 || ^20.9.0 || >=21.1.0"

This drops support for Node.js 12/14/16/17/19.

Is there anything you'd like reviewers to focus on?

Did I miss any places that should be updated?

Drops support for Node.js 12/14/16/17/19 Fixes #17595

netlify · 2023-11-06T22:52:27Z

✅ Deploy Preview for docs-eslint ready!

Name	Link
🔨 Latest commit	`0929225`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/65511f0dc373e100083ffcd4
😎 Deploy Preview	https://deploy-preview-17725--docs-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mdjermanovic · 2023-11-21T13:20:05Z

This is ready for review.

ota-meshi · 2023-11-21T14:18:04Z

What do you think about using Intl.Segmenter instead of graphemer package?

#17595 (comment)

mdjermanovic · 2023-11-24T14:29:25Z

What do you think about using Intl.Segmenter instead of graphemer package?

#17595 (comment)

Makes sense to me, though I'm not sure if we should make changes to the key-spacing rule since it's now deprecated.

Would it be 100% functionally equivalent?

ota-meshi · 2023-11-26T23:45:48Z

I think it is better to reduce the number of dependency packages even if the rules that affect them are deprecated, since it is beneficial for ESLint to reduce the number of dependency packages. What do you think?

Would it be 100% functionally equivalent?

Hmm. It seems that they are not 100% equivalent.
However, I think the purpose of both is the same. I think it would be accepted as a minor breaking change in a major version update, what do you think?

nzakas · 2023-11-30T21:19:03Z

Let's spin off the Intl.Segmenter discussion into a separate issue so we can continue discussing.

kibertoad · 2023-12-02T09:26:21Z

.github/workflows/ci.yml

@@ -45,7 +45,7 @@ jobs:
    strategy:
      matrix:
        os: [ubuntu-latest]
-        node: [21.x, 20.x, 19.x, 18.x, 17.x, 16.x, 14.x, 12.x, "12.22.0"]
+        node: [21.x, 20.x, 18.x, "18.18.0"]


why not 18.x?

There are both 18.x and 18.18.0.

18.x to test on the latest version of Node.js 18 (currently 18.18.2).
18.18.0 to test on the minimum supported version

mdjermanovic · 2023-12-04T09:07:23Z

Let's spin off the Intl.Segmenter discussion into a separate issue so we can continue discussing.

Agreed. @ota-meshi would you like to open an issue to discuss replacing graphemer with Intl.segmenter?

ota-meshi · 2023-12-04T10:57:40Z

Agreed. @ota-meshi would you like to open an issue to discuss replacing graphemer with Intl.segmenter?

I'll do it later when I have time.
If possible, I would like to investigate and show what kind of characters there are differences.

github-actions · 2023-12-14T22:31:38Z

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

aladdin-add

I noticed several things can be updated:

eslint/lib/config/flat-config-schema.js

Lines 12 to 16 in 0dd9704

    
           /* 
        
            * Note: This can be removed in ESLint v9 because structuredClone is available globally 
        
            * starting in Node.js v17. 
        
            */ 
        
           const structuredClone = require("@ungap/structured-clone").default;

eslint/lib/eslint/flat-eslint.js

Lines 12 to 13 in 0dd9704

// Note: Node.js 12 does not support fs/promises.

const fs = require("fs").promises;

sure, it's not a blocker of merging this one, we can update it in another PR later.

mdjermanovic · 2023-12-15T15:02:20Z

I noticed several things can be updated:

eslint/lib/config/flat-config-schema.js

Lines 12 to 16 in 0dd9704

/*

* Note: This can be removed in ESLint v9 because structuredClone is available globally

* starting in Node.js v17.

*/

const structuredClone = require("@ungap/structured-clone").default;

eslint/lib/eslint/flat-eslint.js

Lines 12 to 13 in 0dd9704

// Note: Node.js 12 does not support fs/promises.

const fs = require("fs").promises;

sure, it's not a blocker of merging this one, we can update it in another PR later.

Good catches! I agree, seems best to merge this PR as-is as a starting point when we start with v9 next week, and then make individual changes like these ones and #17835 in separate PRs so that it will be easier to revisit them separately (and revert if needed; hopefully not) later.

* main: (25 commits) test: ensure that CLI tests run with FlatESLint (eslint#17884) fix!: Behavior of CLI when no arguments are passed (eslint#17644) docs: Update README Revert "feat!: Remove CodePath#currentSegments" (eslint#17890) feat!: Update shouldUseFlatConfig and CLI so flat config is default (eslint#17748) feat!: Remove CodePath#currentSegments (eslint#17756) chore: update dependency markdownlint-cli to ^0.38.0 (eslint#17865) feat!: deprecate no-new-symbol, recommend no-new-native-nonconstructor (eslint#17710) feat!: check for parsing errors in suggestion fixes (eslint#16639) feat!: assert suggestion messages are unique in rule testers (eslint#17532) feat!: `no-invalid-regexp` make allowConstructorFlags case-sensitive (eslint#17533) fix!: no-sequences rule schema correction (eslint#17878) feat!: Update `eslint:recommended` configuration (eslint#17716) feat!: drop support for string configurations in flat config array (eslint#17717) feat!: Remove `SourceCode#getComments()` (eslint#17715) feat!: Remove deprecated context methods (eslint#17698) feat!: Swap FlatESLint-ESLint, FlatRuleTester-RuleTester in API (eslint#17823) feat!: remove formatters except html, json(-with-metadata), and stylish (eslint#17531) feat!: Require Node.js `^18.18.0 || ^20.9.0 || >=21.1.0` (eslint#17725) fix: allow circular references in config (eslint#17752) ...

koddsson · 2024-01-10T12:39:46Z

package.json

@@ -170,6 +170,6 @@
  ],
  "license": "MIT",
  "engines": {
-    "node": "^12.22.0 || ^14.17.0 || >=16.0.0"
+    "node": "^18.18.0 || ^20.9.0 || >=21.1.0"


Hey sorry for the random comment but why ^18.18.0 and not ^18.0.0? I've been trying to dig around for this and can't find the reason. I've got the node engine set to >=18 in my app so I'd need to upgrade which is fine, I'm just curious :)

It's the first LTS release for 18

That makes sense but isn't 18.12.0 the first LTS release?

https://nodejs.org/en/blog/release/v18.12.0
https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V18.md#2022-10-25-version-18120-hydrogen-lts-ruyadorno-and-rafaelgss

have you gone through the discussion in the related issue?

have you gone through the discussion in the related issue?

Yeah but I'm missing why those versions were chosen. The only thing I see is it being the latest versions at the time.

feat!: Require Node.js ^18.18.0 || ^20.7.0 || >=21.1.0

f7b482f

Drops support for Node.js 12/14/16/17/19 Fixes #17595

mdjermanovic added core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion labels Nov 6, 2023

eslint-github-bot bot added breaking This change is backwards-incompatible feature This change adds a new feature to ESLint labels Nov 6, 2023

mdjermanovic added 3 commits November 6, 2023 23:56

update getting-started

f4ed1a6

fix lint errors

e3ab365

20.7.0 -> 20.9.0

0929225

mdjermanovic changed the title ~~feat!: Require Node.js ^18.18.0 || ^20.7.0 || >=21.1.0~~ feat!: Require Node.js ^18.18.0 || ^20.9.0 || >=21.1.0 Nov 12, 2023

mdjermanovic mentioned this pull request Nov 12, 2023

Change Request: Drop Node v12/v14/v16/v17/v19 support #17595

Closed

1 task

nzakas approved these changes Nov 30, 2023

View reviewed changes

kibertoad reviewed Dec 2, 2023

View reviewed changes

ota-meshi mentioned this pull request Dec 11, 2023

Change Request: Replace graphemer with Intl.Segmenter #17835

Closed

1 task

github-actions bot added the Stale label Dec 14, 2023

fasttime removed the Stale label Dec 14, 2023

fasttime assigned mdjermanovic Dec 14, 2023

aladdin-add approved these changes Dec 15, 2023

View reviewed changes

mdjermanovic marked this pull request as ready for review December 20, 2023 12:16

mdjermanovic requested a review from a team as a code owner December 20, 2023 12:16

mdjermanovic merged commit e1e827f into main Dec 20, 2023
17 checks passed

mdjermanovic deleted the issue17595 branch December 20, 2023 13:02

koddsson reviewed Jan 10, 2024

View reviewed changes

xiaoxian521 referenced this pull request in pure-admin/vue-pure-admin Jan 13, 2024

chore: 提高node版本要求，为后续升级eslint9做准备

8b51731

hyunbinseo mentioned this pull request Feb 15, 2024

docs: blog post for v7 typescript-eslint/typescript-eslint#8400

Merged

3 tasks

Pewtro mentioned this pull request Apr 8, 2024

error eslint@9.0.0: "node" 20.8.0 is incompatible with this module #18288

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: Require Node.js `^18.18.0 || ^20.9.0 || >=21.1.0` #17725

feat!: Require Node.js `^18.18.0 || ^20.9.0 || >=21.1.0` #17725

mdjermanovic commented Nov 6, 2023 •

edited

netlify bot commented Nov 6, 2023 •

edited

mdjermanovic commented Nov 21, 2023

ota-meshi commented Nov 21, 2023

mdjermanovic commented Nov 24, 2023

ota-meshi commented Nov 26, 2023

nzakas commented Nov 30, 2023

kibertoad Dec 2, 2023

mdjermanovic Dec 4, 2023

mdjermanovic commented Dec 4, 2023

ota-meshi commented Dec 4, 2023

github-actions bot commented Dec 14, 2023

aladdin-add left a comment

mdjermanovic commented Dec 15, 2023

koddsson Jan 10, 2024

kibertoad Jan 10, 2024

koddsson Jan 10, 2024 •

edited

Tanujkanti4441 Jan 10, 2024 •

edited

koddsson Jan 10, 2024

	/*
	* Note: This can be removed in ESLint v9 because structuredClone is available globally
	* starting in Node.js v17.
	*/
	const structuredClone = require("@ungap/structured-clone").default;

	// Note: Node.js 12 does not support fs/promises.
	const fs = require("fs").promises;

feat!: Require Node.js ^18.18.0 || ^20.9.0 || >=21.1.0 #17725

feat!: Require Node.js ^18.18.0 || ^20.9.0 || >=21.1.0 #17725

Conversation

mdjermanovic commented Nov 6, 2023 • edited

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

netlify bot commented Nov 6, 2023 • edited

✅ Deploy Preview for docs-eslint ready!

mdjermanovic commented Nov 21, 2023

ota-meshi commented Nov 21, 2023

mdjermanovic commented Nov 24, 2023

ota-meshi commented Nov 26, 2023

nzakas commented Nov 30, 2023

kibertoad Dec 2, 2023

Choose a reason for hiding this comment

mdjermanovic Dec 4, 2023

Choose a reason for hiding this comment

mdjermanovic commented Dec 4, 2023

ota-meshi commented Dec 4, 2023

github-actions bot commented Dec 14, 2023

aladdin-add left a comment

Choose a reason for hiding this comment

mdjermanovic commented Dec 15, 2023

koddsson Jan 10, 2024

Choose a reason for hiding this comment

kibertoad Jan 10, 2024

Choose a reason for hiding this comment

koddsson Jan 10, 2024 • edited

Choose a reason for hiding this comment

Tanujkanti4441 Jan 10, 2024 • edited

Choose a reason for hiding this comment

koddsson Jan 10, 2024

Choose a reason for hiding this comment

feat!: Require Node.js `^18.18.0 || ^20.9.0 || >=21.1.0` #17725

feat!: Require Node.js `^18.18.0 || ^20.9.0 || >=21.1.0` #17725

mdjermanovic commented Nov 6, 2023 •

edited

netlify bot commented Nov 6, 2023 •

edited

koddsson Jan 10, 2024 •

edited

Tanujkanti4441 Jan 10, 2024 •

edited