Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Swap FlatESLint-ESLint, FlatRuleTester-RuleTester in API #17823

Merged
merged 1 commit into from Dec 20, 2023

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Dec 6, 2023

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Swap APIs.

What changes did you make? (Give an overview)

This PR changes the ESLint and RuleTester exports to point to FlatESLint and FlatRuleTester, respectively. We will do the internal renaming in a separate PR.

Refs #13481

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added breaking This change is backwards-incompatible feature This change adds a new feature to ESLint labels Dec 6, 2023
Copy link

netlify bot commented Dec 6, 2023

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 2ae65f9
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/65709e4642d5ad0008c29d96

@mdjermanovic mdjermanovic changed the title feat!: Swap FlatESLint-ESLint, FlatRuleTeser-RuleTester in API feat!: Swap FlatESLint-ESLint, FlatRuleTester-RuleTester in API Dec 7, 2023
@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Dec 7, 2023
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic added the core Relates to ESLint's core APIs and features label Dec 7, 2023
@mdjermanovic mdjermanovic marked this pull request as ready for review December 20, 2023 13:25
@mdjermanovic mdjermanovic requested a review from a team as a code owner December 20, 2023 13:25
@mdjermanovic mdjermanovic merged commit f71c328 into main Dec 20, 2023
22 checks passed
@mdjermanovic mdjermanovic deleted the api-update branch December 20, 2023 13:28
bmish added a commit to bmish/eslint that referenced this pull request Dec 27, 2023
* main: (25 commits)
  test: ensure that CLI tests run with FlatESLint (eslint#17884)
  fix!: Behavior of CLI when no arguments are passed (eslint#17644)
  docs: Update README
  Revert "feat!: Remove CodePath#currentSegments" (eslint#17890)
  feat!: Update shouldUseFlatConfig and CLI so flat config is default (eslint#17748)
  feat!: Remove CodePath#currentSegments (eslint#17756)
  chore: update dependency markdownlint-cli to ^0.38.0 (eslint#17865)
  feat!: deprecate no-new-symbol, recommend no-new-native-nonconstructor (eslint#17710)
  feat!: check for parsing errors in suggestion fixes (eslint#16639)
  feat!: assert suggestion messages are unique in rule testers (eslint#17532)
  feat!: `no-invalid-regexp` make allowConstructorFlags case-sensitive (eslint#17533)
  fix!: no-sequences rule schema correction (eslint#17878)
  feat!: Update `eslint:recommended` configuration (eslint#17716)
  feat!: drop support for string configurations in flat config array (eslint#17717)
  feat!: Remove `SourceCode#getComments()` (eslint#17715)
  feat!: Remove deprecated context methods (eslint#17698)
  feat!: Swap FlatESLint-ESLint, FlatRuleTester-RuleTester in API (eslint#17823)
  feat!: remove formatters except html, json(-with-metadata), and stylish (eslint#17531)
  feat!: Require Node.js `^18.18.0 || ^20.9.0 || >=21.1.0` (eslint#17725)
  fix: allow circular references in config (eslint#17752)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion breaking This change is backwards-incompatible core Relates to ESLint's core APIs and features feature This change adds a new feature to ESLint
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants