Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: no-sequences rule schema correction #17878

Merged
merged 1 commit into from Dec 20, 2023
Merged

fix!: no-sequences rule schema correction #17878

merged 1 commit into from Dec 20, 2023

Conversation

mho22
Copy link
Contributor

@mho22 mho22 commented Dec 19, 2023

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Refactor an existing rule [ no-sequences ] schema. It lacked a type property with value object. Related link here.

What changes did you make? (Give an overview)

I simply added the missing type property to the no-sequences schema object.

I modified the current schema :

schema: [{
    properties: {
        allowInParentheses: {
            type: "boolean",
            default: true
        }
    },
    additionalProperties: false
}]

Into this :

schema: [{
+   type: "object",
    properties: {
        allowInParentheses: {
            type: "boolean",
            default: true
        }
    },
    additionalProperties: false
}]

Is there anything you'd like reviewers to focus on?

no

@mho22 mho22 requested a review from a team as a code owner December 19, 2023 11:24
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Dec 19, 2023
Copy link

netlify bot commented Dec 19, 2023

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit be11694
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/65817d6084af6d000848ba3d

@mdjermanovic mdjermanovic changed the title chore: no-sequences rule schema correction fix!: no-sequences rule schema correction Dec 19, 2023
@eslint-github-bot eslint-github-bot bot added breaking This change is backwards-incompatible bug ESLint is working incorrectly labels Dec 19, 2023
@mdjermanovic mdjermanovic added rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion and removed chore This change is not user-facing labels Dec 19, 2023
@mdjermanovic mdjermanovic marked this pull request as draft December 19, 2023 11:49
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic marked this pull request as ready for review December 20, 2023 14:22
@mdjermanovic mdjermanovic merged commit e5f02c7 into eslint:main Dec 20, 2023
22 checks passed
@mho22 mho22 deleted the no-sequences-patch branch December 21, 2023 11:31
bmish added a commit to bmish/eslint that referenced this pull request Dec 27, 2023
* main: (25 commits)
  test: ensure that CLI tests run with FlatESLint (eslint#17884)
  fix!: Behavior of CLI when no arguments are passed (eslint#17644)
  docs: Update README
  Revert "feat!: Remove CodePath#currentSegments" (eslint#17890)
  feat!: Update shouldUseFlatConfig and CLI so flat config is default (eslint#17748)
  feat!: Remove CodePath#currentSegments (eslint#17756)
  chore: update dependency markdownlint-cli to ^0.38.0 (eslint#17865)
  feat!: deprecate no-new-symbol, recommend no-new-native-nonconstructor (eslint#17710)
  feat!: check for parsing errors in suggestion fixes (eslint#16639)
  feat!: assert suggestion messages are unique in rule testers (eslint#17532)
  feat!: `no-invalid-regexp` make allowConstructorFlags case-sensitive (eslint#17533)
  fix!: no-sequences rule schema correction (eslint#17878)
  feat!: Update `eslint:recommended` configuration (eslint#17716)
  feat!: drop support for string configurations in flat config array (eslint#17717)
  feat!: Remove `SourceCode#getComments()` (eslint#17715)
  feat!: Remove deprecated context methods (eslint#17698)
  feat!: Swap FlatESLint-ESLint, FlatRuleTester-RuleTester in API (eslint#17823)
  feat!: remove formatters except html, json(-with-metadata), and stylish (eslint#17531)
  feat!: Require Node.js `^18.18.0 || ^20.9.0 || >=21.1.0` (eslint#17725)
  fix: allow circular references in config (eslint#17752)
  ...
@mdjermanovic mdjermanovic mentioned this pull request Dec 29, 2023
3 tasks
@nzakas
Copy link
Member

nzakas commented Jan 4, 2024

Hi there, we'd like to pay you for this contribution. Please contact us at contact (at) eslint (dot) org so we can send you the information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion breaking This change is backwards-incompatible bug ESLint is working incorrectly contributor pool rule Relates to ESLint's core rules
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

3 participants