Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix getting scope in tests #17899

Merged
merged 1 commit into from Dec 22, 2023
Merged

chore: fix getting scope in tests #17899

merged 1 commit into from Dec 22, 2023

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Fixes recently committed tests that were still using now-removed context.getScope().

What changes did you make? (Give an overview)

context.getScope -> context.sourceCode.getScope

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic requested a review from a team as a code owner December 22, 2023 12:36
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Dec 22, 2023
Copy link

netlify bot commented Dec 22, 2023

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit ceaabc1
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/658582e74f0b7c0008dea768

@mdjermanovic
Copy link
Member Author

Since this is a trivial change in tests, I'm going to merge this right away to fix CI.

@mdjermanovic mdjermanovic merged commit a9a17b3 into main Dec 22, 2023
17 checks passed
@mdjermanovic mdjermanovic deleted the tests-getscope branch December 22, 2023 12:44
bmish added a commit to bmish/eslint that referenced this pull request Dec 27, 2023
* main:
  chore: use jsdoc/no-multi-asterisks with allowWhitespace: true (eslint#17900)
  chore: fix getting scope in tests (eslint#17899)
  fix!: Parsing 'exported' comment using parseListConfig (eslint#17675)
  docs: updated examples of `max-lines` rule (eslint#17898)
  feat!: Remove valid-jsdoc and require-jsdoc (eslint#17694)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore This change is not user-facing
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

1 participant