Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: show NEXT in version selectors #17911

Merged
merged 2 commits into from Dec 29, 2023
Merged

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Enables NEXT in version selectors.

What changes did you make? (Give an overview)

  • Set config.showNextVersion to true to enable NEXT in version selectors (see 6669413).
  • Updated eslintVersion to read from config.version, because pkg.version will soon become 9.0.0-alpha.0.

Is there anything you'd like reviewers to focus on?

  • If we merge this now, NEXT will appear in the lists on https://eslint.org/docs/head before the release. Is that okay?
  • When this is merged, I'll sync the next branch.
  • I'll send a separate PR targeting the latest branch to set "showNextVersion": true there.
  • eslintVersion also reads from ESLINT_VERSION environment variable, so we could just set this variable on Netlify instead of hardcoding the latest version in the config file. However, this is a temporary solution anyway, and this will make it more clear where the 8.56.0 value is coming from when we start working on a long-term solution.

@mdjermanovic mdjermanovic requested a review from a team as a code owner December 28, 2023 16:41
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Dec 28, 2023
Copy link

netlify bot commented Dec 28, 2023

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 2a89b9d
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/658daa61441ae10008789f3f
😎 Deploy Preview https://deploy-preview-17911--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd say let's hold off on merging this until we do the release. That should (I think?) update the next branch.

@mdjermanovic
Copy link
Member Author

Yes, we could merge this right before the release, and the next branch will include this commit when the branch gets updated during the release. I'm switching to draft so that we don't accidentally merge this before the time comes.

@mdjermanovic mdjermanovic marked this pull request as draft December 28, 2023 20:02
@mdjermanovic mdjermanovic marked this pull request as ready for review December 29, 2023 23:33
@mdjermanovic mdjermanovic merged commit 7f0ba51 into main Dec 29, 2023
17 checks passed
@mdjermanovic mdjermanovic deleted the docs-show-next-version branch December 29, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants