Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused dependency rimraf #17934

Merged
merged 1 commit into from Jan 1, 2024
Merged

chore: remove unused dependency rimraf #17934

merged 1 commit into from Jan 1, 2024

Conversation

fasttime
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

Remove an unused dependency.

What changes did you make? (Give an overview)

This PR removes rimraf as a dev dependency from docs/package.json.

I noticed that rimraf is showing up on the Renovate dashboard as pending update, but it's apparently not used anywhere.

Feel free to close this PR if rimraf is still being used in a way that I haven't considered.

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Dec 31, 2023
Copy link

netlify bot commented Dec 31, 2023

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 9554494
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6591992ee08f0f000891ce32
😎 Deploy Preview https://deploy-preview-17934--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fasttime fasttime marked this pull request as ready for review December 31, 2023 17:06
@fasttime fasttime requested a review from a team as a code owner December 31, 2023 17:06
@fasttime fasttime added deps:npm dependencies Pull requests that update a dependency file labels Dec 31, 2023
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I see that it was added in #15815, but don't see it being used anywhere.

I'll leave it open for others to review.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 10ed29c into main Jan 1, 2024
17 checks passed
@mdjermanovic mdjermanovic deleted the remove-rimraf branch January 1, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore This change is not user-facing dependencies Pull requests that update a dependency file deps:npm
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

3 participants