Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update docs files when publishing prereleases #17940

Merged
merged 1 commit into from Jan 2, 2024
Merged

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Fixes our release process to update docs files when publishing prereleases, the same as when publishing regular releases.

#17883 (comment)

#17893 (comment)

What changes did you make? (Give an overview)

Merged prerelease-specific logic from function generatePrerelease into function generateRelease so that function generateRelease now handles both releases and prereleases.

Is there anything you'd like reviewers to focus on?

It seems that function generatePrerelease was also supporting prereleases of minor versions. I didn't copy that logic, it was probably needed for 0.x prereleases only.

@mdjermanovic mdjermanovic requested a review from a team as a code owner January 1, 2024 21:36
@eslint-github-bot eslint-github-bot bot added the build This change relates to ESLint's build process label Jan 1, 2024
Copy link

netlify bot commented Jan 1, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit e834472
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6593306ee140190008793a49
😎 Deploy Preview https://deploy-preview-17940--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jan 1, 2024
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'll leave it open for others to review

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit c2bf27d into main Jan 2, 2024
17 checks passed
@nzakas nzakas deleted the prerelease-docs branch January 2, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion build This change relates to ESLint's build process
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

3 participants