Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Explain how to combine configs #17947

Merged
merged 3 commits into from Jan 4, 2024
Merged

docs: Explain how to combine configs #17947

merged 3 commits into from Jan 4, 2024

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Jan 3, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Added a page on how to combine different types of configs into a config array. This applies to shareable configs and plugin configs...and everything in between.

fixes #17844

Is there anything you'd like reviewers to focus on?

@nzakas nzakas requested a review from a team as a code owner January 3, 2024 19:08
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Jan 3, 2024
Copy link

netlify bot commented Jan 3, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 3aa06a6
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/65970faed4ecc60008341712
😎 Deploy Preview https://deploy-preview-17947--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one suggestion to fix the syntax.

docs/src/use/configure/combine-configs.md Outdated Show resolved Hide resolved
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/src/use/configure/combine-configs.md Outdated Show resolved Hide resolved
nzakas and others added 2 commits January 4, 2024 15:05
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Co-authored-by: Nitin Kumar <snitin315@gmail.com>
@nzakas nzakas merged commit 9507525 into main Jan 4, 2024
12 checks passed
@nzakas nzakas deleted the issue17844 branch January 4, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

How to apply a legacy config to specific files
3 participants