Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add more removed context methods to migrate to v9 guide #17951

Merged
merged 2 commits into from Jan 4, 2024

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Adds context.getAncestors(), context.getDeclaredVariables(), context.getScope(), and context.markVariableAsUsed() to the v9 migration guide in the "Removed multiple context methods" section.

What changes did you make? (Give an overview)

Updated v9 migration guide.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic requested a review from a team as a code owner January 4, 2024 09:48
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Jan 4, 2024
Copy link

netlify bot commented Jan 4, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit a54e615
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6597013ccd8286000978edcc
😎 Deploy Preview https://deploy-preview-17951--docs-eslint.netlify.app/use/migrate-to-9.0.0
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdjermanovic
Copy link
Member Author

@christian-bromann this error happens occasionally, and usually disappears when the test is run again:

2024-01-04T09:51:01.6471352Z Execution of 1 workers started at 2024-01-04T09:51:01.644Z
2024-01-04T09:51:01.6475738Z 
2024-01-04T09:51:03.5695259Z [0-0] RUNNING in chrome - file:///tests/lib/linter/linter.js
2024-01-04T09:51:21.2183638Z [0-0]  Error:  Test failed due to following error(s):
2024-01-04T09:51:21.2187139Z   - linter.js: Failed to fetch dynamically imported module: http://localhost:46847/lib/config/flat-config-array.js: TypeError: Failed to fetch dynamically imported module: http://localhost:46847/lib/config/flat-config-array.js
2024-01-04T09:51:21.2189408Z 
2024-01-04T09:51:21.4289266Z [0-0] FAILED in chrome - file:///tests/lib/linter/linter.js
2024-01-04T09:51:21.4799836Z 
2024-01-04T09:51:21.4800947Z  "concise" Reporter:
2024-01-04T09:51:21.4807590Z ========= Your concise report ==========
2024-01-04T09:51:21.4809132Z chrome-headless-shell (v120.0.6099.109) on linux
2024-01-04T09:51:21.4812595Z ❌ Failed to setup tests, no tests found
2024-01-04T09:51:21.4814289Z 
2024-01-04T09:51:21.4815373Z 
2024-01-04T09:51:21.4820184Z Spec Files:	 0 passed, 1 failed, 1 total (100% completed) in 00:00:19 

Any ideas about what's causing it and how we could avoid it?

@christian-bromann
Copy link
Contributor

Any ideas about what's causing it and how we could avoid it?

Thanks for letting me know, seems like a race condition. I will see if I find a way to improve this behavior.

Co-authored-by: Nitin Kumar <snitin315@gmail.com>
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit 7c78576 into main Jan 4, 2024
17 checks passed
@nzakas nzakas deleted the v9-migrate-more-removed-context branch January 4, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

4 participants