feat: maintain latest ecma version in ESLint #17958
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
Fixes #15366
What changes did you make? (Give an overview)
I added configuration for the latest ECMAScript version to ESLint and updated Linter to use it instead of
espree.latestEcmaVersion
when resolving"latest"
value oflanguageOptions.ecmaVersion
.Is there anything you'd like reviewers to focus on?
I didn't change the eslintrc logic:
eslint/lib/linter/linter.js
Lines 553 to 559 in 9507525
because, in eslintrc configs,
ecmaVersion
is inparserOptions
:thus, in this case, I think it makes more sense to keep getting the version from the parser.