Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix number of code-path events on custom rules page #17969

Merged
merged 1 commit into from Jan 7, 2024

Conversation

Richardinho
Copy link
Contributor

@Richardinho Richardinho commented Jan 7, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Fixes #17968

What changes did you make? (Give an overview)

In the section https://eslint.org/docs/latest/extend/custom-rules#accessing-code-paths, the number of code-path events is incorrectly stated as five. I have changed it to seven.

Is there anything you'd like reviewers to focus on?

@Richardinho Richardinho requested a review from a team as a code owner January 7, 2024 18:01
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Jan 7, 2024
Copy link

linux-foundation-easycla bot commented Jan 7, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Richardinho / name: Richard Hunter (7f7b180)

Copy link

netlify bot commented Jan 7, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 7f7b180
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/659ae7194d0a3a00089345bc
😎 Deploy Preview https://deploy-preview-17969--docs-eslint.netlify.app/extend/custom-rules
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdjermanovic mdjermanovic changed the title docs: number of code-path events on custom rules page docs: fix number of code-path events on custom rules page Jan 7, 2024
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit d31c180 into eslint:main Jan 7, 2024
17 checks passed
bmish added a commit to bmish/eslint that referenced this pull request Jan 16, 2024
* main:
  chore: Split Docs CI from core CI (eslint#17897)
  fix: Ensure config keys are printed for config errors (eslint#17980)
  chore: delete relative-module-resolver.js (eslint#17981)
  docs: migration guide entry for `no-inner-declarations` (eslint#17977)
  docs: Update README
  feat: maintain latest ecma version in ESLint (eslint#17958)
  feat!: no-inner-declaration new default behaviour and option (eslint#17885)
  feat: add `no-useless-assignment` rule (eslint#17625)
  fix: `no-misleading-character-class` edge cases with granular errors (eslint#17970)
  feat: `no-misleading-character-class` granular errors (eslint#17515)
  docs: fix number of code-path events on custom rules page (eslint#17969)
  docs: reorder entries in v9 migration guide (eslint#17967)
  fix!: handle `--output-file` for empty output when saving to disk (eslint#17957)
Copy link

@farhan7reza7 farhan7reza7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is meaningful

@Tanujkanti4441
Copy link
Contributor

@farhan7reza7, indeed this change is meaningful here you can see there are seven events related to code-paths.

you can go through the contribute to ESLint page to learn more about how you can contribute to ESLint in different ways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Docs: list wrong number of code path events
4 participants