Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update valid-typeof rule #18001

Merged
merged 1 commit into from Jan 17, 2024
Merged

Conversation

Tanujkanti4441
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

the usual structure of rules docs file is -- rule details < examples < options < option name < examples.
changed the valid-typeof rule docs to follow the same. and changed it's options description a bit.

Is there anything you'd like reviewers to focus on?

@Tanujkanti4441 Tanujkanti4441 requested a review from a team as a code owner January 17, 2024 14:40
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Jan 17, 2024
Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 65a6e09
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/65a7e6e9ce32a40008eb213e
😎 Deploy Preview https://deploy-preview-18001--docs-eslint.netlify.app/rules/valid-typeof
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Tanujkanti4441 Tanujkanti4441 added the rule Relates to ESLint's core rules label Jan 17, 2024
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit 38b9b06 into eslint:main Jan 17, 2024
17 of 18 checks passed
@Tanujkanti4441 Tanujkanti4441 deleted the typeof-docs branch January 18, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants