Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use Node.js 20 for docs sites #18026

Merged
merged 1 commit into from Jan 24, 2024
Merged

chore: use Node.js 20 for docs sites #18026

merged 1 commit into from Jan 24, 2024

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

I've updated configurations on Netlify to use Node.js 20 when building docs and org sites.

This updates docs' package.engines to reflect this environment so that we can use dependencies that don't support older versions of Node.js.

Also updates Node.js version for the Browser test.

What changes did you make? (Give an overview)

Updated engines in docs/package.json, and updated the CI workflow per the above points.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic requested a review from a team as a code owner January 23, 2024 23:30
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Jan 23, 2024
Copy link

netlify bot commented Jan 23, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 7319ccd
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/65b04c07c5138e0008f133f6
😎 Deploy Preview https://deploy-preview-18026--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aladdin-add aladdin-add merged commit dfb68b6 into main Jan 24, 2024
18 checks passed
@aladdin-add aladdin-add deleted the docs-node20 branch January 24, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore This change is not user-facing
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants