Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update team responsibilities #18048

Merged
merged 4 commits into from Feb 3, 2024
Merged

docs: Update team responsibilities #18048

merged 4 commits into from Feb 3, 2024

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Jan 29, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Updated governance docs to make explicit the team member responsibilities discussed internally.

Also deleted the processes for adding different team members as they are handled in our private repo with issue templates.

Is there anything you'd like reviewers to focus on?

@nzakas nzakas requested a review from a team as a code owner January 29, 2024 18:40
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Jan 29, 2024
Copy link

netlify bot commented Jan 29, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 0816faf
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/65bd3ab6c4c8ca0008ba4644
😎 Deploy Preview https://deploy-preview-18048--docs-eslint.netlify.app/contribute/governance
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nzakas
Copy link
Member Author

nzakas commented Jan 29, 2024

@christian-bromann looks like the browser test is failing again. Can you take a look?

Copy link
Member

@harish-sethuraman harish-sethuraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christian-bromann
Copy link
Contributor

christian-bromann commented Jan 29, 2024

@nzakas yes! I have this looked in webdriverio/webdriverio#12056 and is my top priority atm. Can you try to rerun the pipeline to see if it might resolve?

@fasttime
Copy link
Member

The browser test is passing again now 😊

docs/src/contribute/governance.md Outdated Show resolved Hide resolved
docs/src/contribute/governance.md Outdated Show resolved Hide resolved
docs/src/contribute/governance.md Outdated Show resolved Hide resolved
docs/src/contribute/governance.md Outdated Show resolved Hide resolved
nzakas and others added 2 commits January 30, 2024 12:44
Co-authored-by: Francesco Trotta <github@fasttime.org>
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable per internal discussions. I do think it'd be good to iterate on the "once per week day" point - thoughts?

docs/src/contribute/governance.md Outdated Show resolved Hide resolved
@amareshsm amareshsm added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jan 30, 2024
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Member

@amareshsm amareshsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@amareshsm amareshsm merged commit b844324 into main Feb 3, 2024
18 checks passed
@amareshsm amareshsm deleted the team-docs branch February 3, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

8 participants