Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add PR labeler action #18109

Merged
merged 5 commits into from Feb 16, 2024
Merged

ci: add PR labeler action #18109

merged 5 commits into from Feb 16, 2024

Conversation

snitin315
Copy link
Contributor

@snitin315 snitin315 commented Feb 10, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)

Fix #16620

Is there anything you'd like reviewers to focus on?

Notes regarding pull_request_target event. It requires the workflow file to be present at the main branch.

For testing purposes, you can play create PRs in my forked repo - https://github.com/snitin315/eslint/pulls

Copy link

netlify bot commented Feb 10, 2024

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit d2f8a7a
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/65cfbaece37ec40008a9f47e

@eslint-github-bot
Copy link

Hi @snitin315!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@snitin315 snitin315 changed the title Pr labeler action ci: add PR labeler action Feb 10, 2024
@eslint-github-bot eslint-github-bot bot added the build This change relates to ESLint's build process label Feb 10, 2024
@snitin315 snitin315 marked this pull request as ready for review February 12, 2024 07:35
@snitin315 snitin315 requested a review from a team as a code owner February 12, 2024 07:35
@amareshsm amareshsm added the accepted There is consensus among the team that this change meets the criteria for inclusion label Feb 12, 2024
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this! Just a few suggestions.

.github/labeler.yml Outdated Show resolved Hide resolved
.github/labeler.yml Outdated Show resolved Hide resolved
@@ -0,0 +1,29 @@
documentation:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do already have the same label coming from our github bot. Should we do this from both the places or keep one alive?

Copy link
Contributor Author

@snitin315 snitin315 Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bot attaches the label as per the PR title, it's fine to keep it at both places. Also, this is yet to be implemented in other eslint repositories.

@amareshsm amareshsm removed the build This change relates to ESLint's build process label Feb 14, 2024
@eslint-github-bot eslint-github-bot bot added the build This change relates to ESLint's build process label Feb 14, 2024
.github/labeler.yml Outdated Show resolved Hide resolved
.github/labeler.yml Outdated Show resolved Hide resolved
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's try it out and see how it goes. :)

@nzakas nzakas merged commit cace6d0 into main Feb 16, 2024
16 of 17 checks passed
@nzakas nzakas deleted the pr-labeler-action branch February 16, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion build This change relates to ESLint's build process
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Standardize auto-labeling
4 participants