Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update link for schema examples #18112

Merged
merged 1 commit into from Feb 12, 2024
Merged

Conversation

Svetzayats
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Link to examples of JSON Schema led to 404. Updated to actual link.

Is there anything you'd like reviewers to focus on?

No.

@Svetzayats Svetzayats requested a review from a team as a code owner February 11, 2024 13:22
Copy link

linux-foundation-easycla bot commented Feb 11, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Svetzayats / name: Svetlana (eb6ffd0)

@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Feb 11, 2024
Copy link

netlify bot commented Feb 11, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit eb6ffd0
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/65c8ca0b871b200008abaef1
😎 Deploy Preview https://deploy-preview-18112--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Tanujkanti4441
Copy link
Contributor

Hi @Svetzayats, thanks for the PR a good catch, can you also sign CLA.

@Svetzayats
Copy link
Contributor Author

Svetzayats commented Feb 11, 2024

Hi, @Tanujkanti4441 , I signed CLA, thank you for the reminder. Is there anything else needed to do?

@Tanujkanti4441 Tanujkanti4441 added bug ESLint is working incorrectly accepted There is consensus among the team that this change meets the criteria for inclusion labels Feb 11, 2024
@Tanujkanti4441
Copy link
Contributor

Hi, @Tanujkanti4441 , I signed CLA, thank you for the reminder. Is there anything else needed to do?

The change looks good to me, if there will anything we will let you know through a change request.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit d8068ec into eslint:main Feb 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

3 participants