Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync-labels value of pr-labeler #18124

Merged
merged 1 commit into from Feb 18, 2024
Merged

Conversation

Tanujkanti4441
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)

the value of sync-labels in new pr-labeler's workflow file should be a boolean and ci is failing due to this.
Screenshot 2024-02-18 at 13-06-48 feat no-restricted-imports option added allowImportNames · eslint_eslint@7f52cd5

change sync-labels value to true

Is there anything you'd like reviewers to focus on?

@Tanujkanti4441 Tanujkanti4441 requested a review from a team as a code owner February 18, 2024 07:40
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Feb 18, 2024
Copy link

netlify bot commented Feb 18, 2024

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit b705e38
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/65d1b47ef80afa00089fe2a3

@amareshsm amareshsm added the accepted There is consensus among the team that this change meets the criteria for inclusion label Feb 18, 2024
Copy link
Member

@amareshsm amareshsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad! Thanks for the quick fix.

@snitin315 snitin315 changed the title fix: sync-labels value of pa-labeler fix: sync-labels value of pr-labeler Feb 18, 2024
@aladdin-add
Copy link
Member

ci is failing as webdriverio/webdriverio#12251.

@snitin315 snitin315 merged commit bf0c7ef into eslint:main Feb 18, 2024
16 of 18 checks passed
@Tanujkanti4441 Tanujkanti4441 deleted the fix-labeler branch February 18, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

4 participants