Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add inline cases condition in no-fallthrough #18158

Merged
merged 1 commit into from Feb 29, 2024

Conversation

Tanujkanti4441
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

no-fallthrough rule docs says

By default, this rule does not require a fallthrough comment after an empty case only if the empty case and the next case are on the same line or on consecutive lines.

docs already has an example with consecutive lines and this PR adds the example with the same line condition.

Is there anything you'd like reviewers to focus on?

@Tanujkanti4441 Tanujkanti4441 requested a review from a team as a code owner February 29, 2024 17:13
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Feb 29, 2024
Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 62a53bc
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/65e0bb34556f7200084b0fc2
😎 Deploy Preview https://deploy-preview-18158--docs-eslint.netlify.app/rules/no-fallthrough
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@amareshsm amareshsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Leaving this open for the 2nd review.

@nzakas
Copy link
Member

nzakas commented Feb 29, 2024

@amareshsm please remember to move PRs like this to "Implementing" on the triage board.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit e5ef3cd into eslint:main Feb 29, 2024
19 checks passed
@Tanujkanti4441 Tanujkanti4441 deleted the docs-example branch March 1, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

3 participants