Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove invalid type in @eslint/js #18164

Merged
merged 1 commit into from Mar 4, 2024
Merged

chore: remove invalid type in @eslint/js #18164

merged 1 commit into from Mar 4, 2024

Conversation

snitin315
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

No

@snitin315 snitin315 requested a review from a team as a code owner March 3, 2024 07:25
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Mar 3, 2024
Copy link

netlify bot commented Mar 3, 2024

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 1b0279c
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/65e425d00b961c00080d3276

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Waiting for consensus in #18100.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nzakas nzakas merged commit 972ef15 into main Mar 4, 2024
18 checks passed
@nzakas nzakas deleted the rm-type-import branch March 4, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore This change is not user-facing
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Bug: Types used in JSDoc blocks of @eslint/js are missing
3 participants