Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Explain Node.js version support #18176

Merged
merged 2 commits into from Mar 7, 2024
Merged

docs: Explain Node.js version support #18176

merged 2 commits into from Mar 7, 2024

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Mar 6, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Added a FAQ to the README explaining how we devise our Node.js support for each major release. I based this one what we've actually done the past two releases, but feel free to leave feedback if what I've written doesn't match up with reality.

fixes #11022

Is there anything you'd like reviewers to focus on?

@nzakas nzakas requested a review from a team as a code owner March 6, 2024 20:16
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Mar 6, 2024
@github-actions github-actions bot removed the documentation Relates to ESLint's documentation label Mar 6, 2024
Copy link

netlify bot commented Mar 6, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 9294cf2
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/65ea1be65c967400084b45cb
😎 Deploy Preview https://deploy-preview-18176--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aladdin-add aladdin-add added documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion labels Mar 7, 2024
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
@github-actions github-actions bot removed the documentation Relates to ESLint's documentation label Mar 7, 2024
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit c7abd89 into main Mar 7, 2024
18 checks passed
@mdjermanovic mdjermanovic deleted the issue11022 branch March 7, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Decide how to manage support for minor versions of Node
3 participants