Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove some uses of lodash.merge #18179

Merged
merged 1 commit into from Mar 7, 2024
Merged

chore: Remove some uses of lodash.merge #18179

merged 1 commit into from Mar 7, 2024

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Refs #18160

Removes uses of lodash.merge in non-production code.

What changes did you make? (Give an overview)

Replaced use of lodash.merge with other methods in eslint.config.js of this project and tests for the no-invalid-this rule.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing labels Mar 7, 2024
@mdjermanovic mdjermanovic requested a review from a team as a code owner March 7, 2024 13:44
Copy link

netlify bot commented Mar 7, 2024

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit ab3bdea
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/65e9c4b4e498a80008791bda

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nzakas nzakas merged commit 925afa2 into main Mar 7, 2024
18 checks passed
@nzakas nzakas deleted the issue18160-1 branch March 7, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants