Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #18213

Merged
merged 1 commit into from Mar 16, 2024
Merged

chore: fix some comments #18213

merged 1 commit into from Mar 16, 2024

Conversation

avoidaway
Copy link
Contributor

@avoidaway avoidaway commented Mar 16, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@avoidaway avoidaway requested a review from a team as a code owner March 16, 2024 07:27
Copy link

linux-foundation-easycla bot commented Mar 16, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Mar 16, 2024
Copy link

netlify bot commented Mar 16, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 054cd2f
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/65f54e4500c97e00084a8d32
😎 Deploy Preview https://deploy-preview-18213--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

docs/src/rules/valid-typeof.md Outdated Show resolved Hide resolved
@Tanujkanti4441 Tanujkanti4441 added the accepted There is consensus among the team that this change meets the criteria for inclusion label Mar 16, 2024
chore: fix some comments

Signed-off-by: avoidaway <cmoman@126.com>
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Leaving open for @Tanujkanti4441 to verify.

Copy link
Contributor

@Tanujkanti4441 Tanujkanti4441 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@mdjermanovic mdjermanovic merged commit 1b841bb into eslint:main Mar 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

3 participants