feat: Add --inspect-config CLI flag #18270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
fasttime
previously approved these changes
Apr 5, 2024
Comment on lines
-70
to
-73
| --no-eslintrc Disable use of configuration from .eslintrc.* | ||
| -c, --config path::String Use this configuration, overriding .eslintrc.* config options if present | ||
| --env [String] Specify environments | ||
| --ext [String] Specify JavaScript file extensions |
There was a problem hiding this comment.
Is it intended that --no-eslintrc, --env and --ext are no longer listed in this section, but still have dedicated paragraphs below?
There was a problem hiding this comment.
Yes. We are switching to show the default output everyone sees, but keeping the individual descriptions available so people can still look up the older options.
| --fix Automatically fix problems | ||
| --fix-dry-run Automatically fix problems without saving the changes to the file system | ||
| --fix-type Array Specify the types of fixes to apply (directive, problem, suggestion, layout) | ||
|
|
||
| Ignore files: | ||
| --ignore-path path::String Specify path of ignore file |
There was a problem hiding this comment.
--ignore-path still has a paragraph below.
There was a problem hiding this comment.
Yup, that's because it's still valid in eslintrc mode.
fasttime
added
the
accepted
30 tasks
Co-authored-by: Francesco Trotta <github@fasttime.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[x] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Added the
--inspect-configCLI flag only in flat config mode. I also updated the docs and relevant tests.I updated the CLI docs to use the flag config output.
It looks like we don't have any real tests for the functionality like
--init, so I opted not to add any for this either.fixes #18255
Is there anything you'd like reviewers to focus on?