Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore /docs/v8.x in link checker #18274

Merged
merged 1 commit into from Apr 5, 2024
Merged

chore: ignore /docs/v8.x in link checker #18274

merged 1 commit into from Apr 5, 2024

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Apr 5, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

After we release v9.0.0 final, a /docs/v8.x link will appear on the versions page, and then our link check (npm run lint:links in docs/; we're running this check in CI) will fail.

What changes did you make? (Give an overview)

Added "/docs/v8.x" to skipPatterns.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Apr 5, 2024
@mdjermanovic mdjermanovic requested a review from a team as a code owner April 5, 2024 13:54
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Apr 5, 2024
Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit eb1fc97
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/661002b067609d0008b0b875
😎 Deploy Preview https://deploy-preview-18274--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the documentation Relates to ESLint's documentation label Apr 5, 2024
@mdjermanovic mdjermanovic requested a review from nzakas April 5, 2024 18:14
@nzakas nzakas merged commit d73a33c into main Apr 5, 2024
19 checks passed
@nzakas nzakas deleted the links-ignore-v8 branch April 5, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants