Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add eslintrc-only note to --rulesdir #18281

Merged
merged 1 commit into from Apr 7, 2024
Merged

Conversation

adamlui
Copy link
Contributor

@adamlui adamlui commented Apr 6, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Added eslintrc-only note to --rulesdir copied from other args deprecated as of v9

Is there anything you'd like reviewers to focus on?

Fixes potential confusion for pre-v9 users who bumped and use invalid args similar to #18280 (also probably a good idea to indicate to users who bumped that eslintrc is not even supported anymore in error msg if eslintrc was being used)

@adamlui adamlui requested a review from a team as a code owner April 6, 2024 14:34
@eslint-github-bot
Copy link

Hi @adamlui!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

Copy link

linux-foundation-easycla bot commented Apr 6, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the documentation Relates to ESLint's documentation label Apr 6, 2024
Copy link

netlify bot commented Apr 6, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 4f3fc1b
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/66115d665cbcd50008236651
😎 Deploy Preview https://deploy-preview-18281--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adamlui adamlui changed the title Added eslintrc-only note to --rulesdir (fixes #18280) docs: add eslintrc-only note to --rulesdir (fixes #18280) Apr 6, 2024
@adamlui adamlui changed the title docs: add eslintrc-only note to --rulesdir (fixes #18280) docs: add eslintrc-only note to --rulesdir Apr 6, 2024
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime added the accepted There is consensus among the team that this change meets the criteria for inclusion label Apr 7, 2024
@fasttime fasttime merged commit 5c35321 into eslint:main Apr 7, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants