chore: drop Node < 18 and use @eslint/js v9 in eslint-config-eslint #18323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjermanovic
added
the
accepted
✅ Deploy Preview for docs-eslint canceled.
|
mdjermanovic
commented
Apr 12, 2024
| @@ -68,7 +68,6 @@ const jsConfigs = [js.configs.recommended, { | |||
| "no-caller": "error", | |||
| "no-confusing-arrow": "error", | |||
| "no-console": "error", | |||
| "no-constant-binary-expression": "error", | |||
There was a problem hiding this comment.
This rule is now in the recommended config so no need to enable it here again.
aladdin-add
requested changes
Apr 12, 2024
|
Good catch! Fixed in 31129e1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Updates
eslint-config-eslintto use@eslint/jsv9. Also updates itspackage.enginesaccordingly.What changes did you make? (Give an overview)
Updated eslint-config-eslint as per the above.
Is there anything you'd like reviewers to focus on?