Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix missing accessible name for scroll-to-top link #18329

Merged

Conversation

germanfrelo
Copy link
Contributor

@germanfrelo germanfrelo commented Apr 13, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

I added a missing accessible name to the scroll-to-top link on the website, to comply with the WCAG 2.2 Success Criterion 2.4.4: Link Purpose (In Context), just like the menu button and the logo link (for example).

More info:

Is there anything you'd like reviewers to focus on?

No.

Copy link

linux-foundation-easycla bot commented Apr 13, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Apr 13, 2024
Copy link

netlify bot commented Apr 13, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 1d9dc0c
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/661a3f51741c7e0008896b6f
😎 Deploy Preview https://deploy-preview-18329--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@germanfrelo germanfrelo marked this pull request as ready for review April 13, 2024 08:35
@germanfrelo germanfrelo requested a review from a team as a code owner April 13, 2024 08:35
Copy link
Member

@kecrily kecrily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Apr 13, 2024
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 71c771f into eslint:main Apr 13, 2024
19 checks passed
@germanfrelo germanfrelo deleted the docs/scroll-top-accessible-name branch April 13, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

4 participants