Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lint docs/src/_data js files #18335

Merged
merged 1 commit into from Apr 14, 2024
Merged

chore: lint docs/src/_data js files #18335

merged 1 commit into from Apr 14, 2024

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Includes docs/src/_data files in js linting.

What changes did you make? (Give an overview)

Updated ignore patterns in eslint.config.js to not ignore files in docs/src/_data, and fixed reported lint errors in those files.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic requested a review from a team as a code owner April 13, 2024 23:12
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Apr 13, 2024
Copy link

netlify bot commented Apr 13, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit ccf20ed
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/661b11684d6e790008f0f3f1
😎 Deploy Preview https://deploy-preview-18335--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Apr 13, 2024
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mdjermanovic mdjermanovic merged commit 9048e21 into main Apr 14, 2024
19 checks passed
@mdjermanovic mdjermanovic deleted the lint-docs-data branch April 14, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants