Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: reflect release of v9 in config migration guide #18412

Merged
merged 1 commit into from
May 6, 2024

Conversation

pwbriggs
Copy link
Contributor

@pwbriggs pwbriggs commented May 3, 2024

Update the eslintrc to flat config migration guide with the release of 9.0.0.

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

I changed "Configuration Migration Guide" to reflect that ESLint 9.0.0 has been released.

Is there anything you'd like reviewers to focus on?

Not sure of this is the best wording. It's unclear how this is different from usage in v8, as described in the following paragraph.

Update the eslintrc-to-flat config migration guide with the release of 9.0.0.
@pwbriggs pwbriggs requested a review from a team as a code owner May 3, 2024 03:43
Copy link

linux-foundation-easycla bot commented May 3, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label May 3, 2024
Copy link

netlify bot commented May 3, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 97e28b5
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/66345d68c1e10800088e97bf
😎 Deploy Preview https://deploy-preview-18412--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just need to wait until start of next week to merge.

@pwbriggs pwbriggs requested a review from nzakas May 4, 2024 00:33
@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label May 6, 2024
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

3 participants